Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add JsonSchemaAs impl for IfIsHumanReadable #717

Merged
merged 1 commit into from
Mar 8, 2024

Conversation

swlynch99
Copy link
Contributor

It looks like IfIsHumanReadable was added after I wrote all the existing impls so here's a bonus PR!

This one is straightforward. serde_json always has is_human_readable set to true so we use the schema for the human readable variant. I have also included a test to that effect.

@swlynch99 swlynch99 force-pushed the schemars-if-is-human-readable branch from 395d896 to bb2ab60 Compare March 8, 2024 20:55
Copy link

codecov bot commented Mar 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.64%. Comparing base (4c05768) to head (bb2ab60).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #717   +/-   ##
=======================================
  Coverage   65.64%   65.64%           
=======================================
  Files          38       38           
  Lines        2343     2343           
=======================================
  Hits         1538     1538           
  Misses        805      805           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jonasbb jonasbb merged commit ffade77 into jonasbb:master Mar 8, 2024
22 checks passed
@swlynch99 swlynch99 deleted the schemars-if-is-human-readable branch March 8, 2024 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants